Refactor view #14
Draft
Refactor view #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darn ImportError...
okay actually 97% but close enough
Seems useful to list env to distuingish release from other releases. Also we don't need a release number at the moment. It would take extra work to do note_format so not doing at the moment. Renaming JIRA_TICKETS_NUM to NUM_TICKETS so we it applies even if we switch away from jira.
no longer used
caleb15
commented
Aug 11, 2021
| [ | ||
| "github token", | ||
| "0782415", | ||
| "8038fc3", |
There was a problem hiding this comment.
These shas were from https://github.com/15five/fifteen5-deploy, I updated them to shas from this repo
MVP and all that jazz
also do raise for status so future errors dont happen silently
the header is plaintext so I shouldn't do markdown
caleb15
commented
Aug 13, 2021
| for label in labels: | ||
| if label.startswith(category_indicator): | ||
| return label.replace(category_indicator, "") | ||
| return "Uncategorized" |
There was a problem hiding this comment.
Totally forgot about https://github.com/15five/dev-discussions/issues/117#issuecomment-839225813 -_-
I'll need to add a new thing to extra category from the Jira ticket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://github.com/15five/dev-discussions/issues/117
RELEASES
Closes DEV-1432 Change presentation of release notes